[feaLib] Support subtable statements in more lookups #3800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc25253 to
3d0aa5f
Compare
|
I don't feel qualified to review this. Simon maybe? |
3d0aa5f to
77e9bb5
Compare
With the last commit, buildMarkBasePos() is now unused, but it didn’t do anything anyway, it simply called buildMarkBasePosSubtable() and had a comment about a possible future optimization that was never done in 9+ years.
77e9bb5 to
8fed9ec
Compare
|
I have convinced myself this is a low risk, uncontroversial change, so I’m going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for subtable statements to cursive and mark to base lookups.