8000 [feaLib] Support creating extension lookups by khaledhosny · Pull Request #3811 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[feaLib] Support creating extension lookups #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[feaLib] Support creating extension lookups #3811

merged 1 commit into from
Apr 24, 2025

Conversation

khaledhosny
Copy link
Collaborator

Respect useExtension keyword instead of silently ignoring it.

anthrotype
anthrotype approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last! LGTM, thanks.

Curious what's your use case? Are you working on some sort of FEA decompiler or you feel like you need more direct control on which lookups need extensions because the compiler's offset-overflow-fixing mechanism isn't sufficient?

@khaledhosny
Copy link
Collaborator Author
khaledhosny commented Apr 24, 2025 •
edited
Loading

I'm working on a VOLT compiler that goes VOLT -> FEA -> binary (see the voltlib-build branch).

I initially thought it would be easier than compiling to binary directly since we already had voltToFea, but I keep hitting these little issues.

Anyway, this still useful in case one wants to convert from VOLT to FEA permanently and make it the canonical source.

@khaledhosny khaledhosny marked this pull request as draft April 24, 2025 11:53
@khaledhosny
Copy link
Collaborator Author

This still does not handle implicitly created lookups.

@khaledhosny
[feaLib] Support creating extension lookups
a74cb21 
Respect useExtension keyword instead of silently ignoring it.
@khaledhosny khaledhosny force-pushed the fealib-useExtension branch from 2a093d7 to a74cb21 Compare April 24, 2025 12:15
@khaledhosny khaledhosny marked this pull request as ready for review April 24, 2025 12:17
@khaledhosny khaledhosny merged commit a1c189b into main Apr 24, 2025
11 checks passed
@khaledhosny khaledhosny deleted the fealib-useExtension branch April 24, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaledhosny @anthrotype
0