Add typing for the simpler STAT arguments #3812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as general creature comforts, this avoids popular Python type checkers assuming that the elided fallback name argument can only accept an integer.
Hoolean
added a commit
to daltonmaag/statmake
that referenced
this pull request
Apr 25, 2025
See fonttools/fonttools#3812 - the internal implementation of the name- -adding function does a type check against dict, and so this type is explicitly required by the builder function argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as general creature comforts, this avoids popular Python type checkers assuming that the elided fallback name argument can only accept an integer.