8000 feat(pulumi): expose rds cluster id by gfyrag · Pull Request #933 · formancehq/ledger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(pulumi): expose rds cluster id #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

feat(pulumi): expose rds cluster id #933

merged 1 commit into from
May 19, 2025

Conversation

gfyrag
Copy link
Contributor
@gfyrag gfyrag commented May 19, 2025

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner May 19, 2025 15:17
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 19, 2025 •
edited
Loading

Walkthrough

A minor formatting adjustment was made to the RDSComponentArgs struct for field alignment. Additionally, the newRDSDatabaseComponent function now exports the RDS cluster ID using ctx.Export after the cluster is created and before resource outputs are registered. No other logic or control flow was changed.

Changes

File(s) Change Summary
deployments/pulumi/pkg/storage/component_rds.go Formatted struct field alignment in RDSComponentArgs; added export of RDS cluster ID in newRDSDatabaseComponent using ctx.Export.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PulumiContext as ctx
    participant RDSComponent

    User->>RDSComponent: Call newRDSDatabaseComponent()
    RDSComponent->>PulumiContext: Create RDS Cluster
    RDSComponent->>PulumiContext: ctx.Export("rds-cluster-id", cluster.ID())
    RDSComponent->>PulumiContext: Register resource outputs
Loading

Suggested reviewers

  • paul-nicolas
  • flemzord

Poem

In the code where clusters dwell,
A tiny tweak, a tale to tell—
Now the cluster’s ID shines bright,
Exported for all, a guiding light.
With structs aligned and fields in row,
The rabbit hops—onward we go! 🐇

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c752c1b and fac84d1.

📒 Files selected for processing (1)
  • deployments/pulumi/pkg/storage/component_rds.go (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
deployments/pulumi/pkg/storage/component_rds.go (1)
deployments/pulumi/pkg/storage/setup_rds.go (1)
  • RDSClusterCreateArgs (10-20)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Tests
  • GitHub Check: Dirty
🔇 Additional comments (2)
deployments/pulumi/pkg/storage/component_rds.go (2)

13-14: LGTM! Improved field alignment.

The field alignment in the RDSComponentArgs struct has been properly formatted, which improves code readability.

134-135: LGTM! Exposing RDS cluster ID as a stack output.

This change correctly exports the RDS cluster ID as a Pulumi stack output, making it accessible to consumers of the stack. The export is placed at the appropriate location - after the cluster is created but before registering resource outputs.

The exported ID can be useful for:

  • External integrations that need to reference this specific RDS cluster
  • Monitoring or management tools that work with the RDS cluster ID
  • Cross-stack references where other Pulumi stacks need this cluster's identifier
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Commit Unit Tests in branch feat/pulumi-expose-rds-cluster-id
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gfyrag gfyrag enabled auto-merge May 19, 2025 15:18
@codecov Codecov
Copy link
codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (c752c1b) to head (fac84d1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   82.35%   82.25%   -0.11%     
==========================================
  Files         141      141              
  Lines        7786     7786              
==========================================
- Hits         6412     6404       -8     
- Misses       1051     1057       +6     
- Partials      323      325       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gfyrag gfyrag added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 3d03c93 May 19, 2025
9 of 10 checks passed
@gfyrag gfyrag deleted the feat/pulumi-expose-rds-cluster-id branch May 19, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fguery fguery fguery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyrag @fguery
0