8000 fix(payments): Ensure that payment adjustment references are persisted by laouji · Pull Request #429 · formancehq/payments · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(payments): Ensure that payment adjustment references are persisted #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix(payments): Ensure that payment adjustment references are persisted #429

merged 1 commit into from
Apr 30, 2025

Conversation

laouji
Copy link
Contributor
@laouji laouji commented Apr 30, 2025

Fixes: PMNT-97

@laouji laouji requested a review from a team as a code owner April 30, 2025 11:12
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Apr 30, 2025 •
edited
Loading

Walkthrough

The PaymentAdjustment struct in the codebase has been updated to ensure its Reference field is included during JSON serialization and deserialization. The MarshalJSON and UnmarshalJSON methods were modified so that the Reference attribute is now properly handled when converting to and from JSON. No changes were made to method signatures or other struct fields.

Changes

File(s) Change Summary
internal/models/payment_adjustments.go Updated MarshalJSON and UnmarshalJSON methods of PaymentAdjustment to handle Reference.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Ensure Payment Adjustment Reference is persisted (PMNT-97) ✅

Poem

A hop and a skip through the code we go,
Now "Reference" in JSON will always show.
No more fields lost in marshaling haze,
Adjustments are clear in all future days.
🐇✨ JSON’s delight, everything’s right!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a6a47a and 6efc2c9.

📒 Files selected for processing (1)
  • internal/models/payment_adjustments.go (4 hunks)
🔇 Additional comments (5)
internal/models/payment_adjustments.go (5)

43-43: Good addition - Reference field properly included in JSON serialization.

Adding the Reference field to the anonymous struct ensures it will be included in the JSON output when marshaling PaymentAdjustment objects.

52-52: Correctly mapping the reference value during marshaling.

The value is properly assigned from the source struct to ensure the reference is included in the serialized JSON output.

65-65: Good addition - Reference field included in unmarshaling struct.

Adding the Reference field to the auxiliary struct ensures it will be properly extracted from JSON input.

84-84: Correctly assigning the reference value during unmarshaling.

This assignment ensures the Reference field value from JSON is properly stored in the PaymentAdjustment struct.

9-34:

✅ Verification successful

Verify that the implementation matches all usage patterns.

The changes look good and correctly implement JSON serialization of the Reference field. Consider verifying that all code that creates or updates PaymentAdjustment objects properly sets the Reference field to ensure consistency.

🏁 Script executed:

#!/bin/bash
# Search for places where PaymentAdjustment structs are created or modified
echo "Looking for PaymentAdjustment creation patterns..."
rg --type go "PaymentAdjustment\{" -A 10 
echo "Looking for PaymentAdjustment field assignments..."
rg --type go "\.Reference\s*="

Length of output: 22504

All PaymentAdjustment.Reference Usages Verified

A search across all struct instantiations and field assignments confirms that every creation or update of PaymentAdjustment (in models, storage layers, API handlers, and tests) sets the Reference field (from.Reference, adj.Reference, req.Reference, etc.). The JSON serialization change for Reference is fully compatible with existing usage patterns—no further updates are needed.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link
codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.11%. Comparing base (0a6a47a) to head (6efc2c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/models/payment_adjustments.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   61.12%   61.11%   -0.01%     
==========================================
  Files         579      579              
  Lines       29418    29422       +4     
==========================================
  Hits        17982    17982              
- Misses      10470    10474       +4     
  Partials      966      966

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laouji laouji merged commit 77d40d0 into main Apr 30, 2025
7 of 9 checks passed
@laouji laouji deleted the PMNT-97 branch April 30, 2025 11:19
paul-nicolas pushed a commit that referenced this pull request Apr 30, 2025
@laouji @paul-nicolas
Ensure that payment adjustment references are persisted (#429)
0736aa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-nicolas paul-nicolas paul-nicolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laouji @paul-nicolas
0