fix(pools): do not send event for deletion of not found pools #205
Conversation
|
Warning Rate limit exceeded@paul-nicolas has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 8 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internal/storage/pools.go (1)
116-119: Consider potential race condition in rows affected check.There's a small window between checking rows affected and committing the transaction where another transaction could modify the data. While this is a minor concern in this case (as we're only using it for event notification), it's worth noting.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
internal/connectors/engine/engine.go(1 hunks)internal/storage/pools.go(1 hunks)internal/storage/pools_test.go(2 hunks)internal/storage/storage.go(1 hunks)internal/storage/storage_generated.go(1 hunks)
🔇 Additional comments (5)
internal/storage/pools.go (1)
93-121: LGTM! The implementation correctly handles pool deletion status.
The changes properly track whether a pool was actually deleted by checking the rows affected, which aligns with the PR objective of preventing events for non-existent pools.
internal/storage/storage.go (1)
99-99: LGTM! Interface change properly reflects the new contract.
The updated method signature correctly specifies the new return type, maintaining consistency with the implementation.
internal/storage/pools_test.go (1)
187-189: LGTM! Comprehensive test coverage for the new functionality.
The test cases thoroughly verify both scenarios:
- Deletion of non-existent pool returns (false, nil)
- Deletion of existing pool returns (true, nil)
This ensures the new boolean return value correctly indicates whether a pool was actually deleted.
Also applies to: 198-200
internal/connectors/engine/engine.go (1)
876-903: LGTM! The changes correctly implement the desired behavior.
The modifications ensure that deletion events are only sent when a pool is actually deleted, preventing unnecessary event emissions for non-existent pools. The implementation maintains proper error handling and telemetry.
internal/storage/storage_generated.go (1)
904-909: LGTM! The mock implementation correctly reflects the interface changes.
The PoolsDelete mock method has been properly updated to return both the deletion status and error, maintaining consistency with the actual implementation.
Fixes ENG-1566