-
Notifications
You must be signed in to change notification settings - Fork 7
fix: (temporal) skip deleting workflows when they are already completed #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a comprehensive set of mock implementations for client interfaces in the Temporal SDK, specifically within the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 72.86% 71.60% -1.26%
==========================================
Files 538 540 +2
Lines 26986 27532 +546
==========================================
+ Hits 19664 19715 +51
- Misses 6259 6754 +495
Partials 1063 1063 ☔ View full report in Codecov by Sentry. |
bba4a3e
to
d2fd48f
Compare
d2fd48f
to
a63e01f
Compare
@@ -13,16 +14,20 @@ func (a Activities) TemporalScheduleDelete(ctx context.Context, scheduleID strin | |||
err := handle.Delete(ctx) | |||
if err != nil { | |||
var applicationErr *temporal.ApplicationError | |||
var notFoundErr *serviceerror.NotFound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch !
@@ -0,0 +1,792 @@ | |||
// Code generated by MockGen. DO NOT EDIT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add this file in the exclude files of code coverage ?
If a schedule doesn't exist anymore (was previously terminated manually or otherwise) we get an infinite loop in the connector uninstall child workflow with this error:
Was able to confirm we can catch the
serviceerror.NotFound
type correctly using the debug message: