Move version code and name to binary config from forma config #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially we could have multiple binaries in the project with different versioning. |
michaem
reviewed
Nov 7, 2021
| @@ -4,6 +4,6 @@ import com.stepango.blockme.common.util.clock.Clock | |||
|
|
|||
| class AppClock : Clock { | |||
|
|
|||
| override fun currentTimeMillis(): Long = | |||
| System.currentTimeMillis() | |||
| override fun currentTimeMillis(): Long = | |||
There was a problem hiding this comment.
Unusable code formating changes
| @@ -94,7 +93,8 @@ class CharactersListFragment : | |||
| is CharactersListViewEvent.OpenCharacterDetail -> | |||
| findNavController().navigate( | |||
| CharactersListFragmentDirections | |||
| .actionCharactersListFragmentToCharacterDetailFragment(viewEvent.id)) | |||
| .actionCharactersListFragmentToCharacterDetailFragment(viewEvent.id) | |||
| @@ -1,6 +1,8 @@ | |||
| androidBinary( | |||
| packageName = "com.stepango.blockme.app", | |||
| owner = Teams.core, | |||
| versionCode = 1, | |||
There was a problem hiding this comment.
I think, better to move out BuildConfig definitions from android binaries and just passing to them already created, immutable version of type configuration: DebugBuildConfig, ReleaseBuildConfig and etc.
# Conflicts: # application/build.gradle.kts
stepango
previously approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82