8000 Fix GHA workflow to build and deploy Docker image by etal · Pull Request #61 · formbio/laava · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix GHA workflow to build and deploy Docker image #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix GHA workflow to build and deploy Docker image #61

merged 1 commit into from
Oct 16, 2024

Conversation

etal
Copy link
Contributor
@etal etal commented Oct 16, 2024

Previously the attestation step failed because it (a) didn't specify the Docker image tag, i.e. :latest, and (b) didn't reference the newly built container image's digest correctly. This PR fixes both issues.

8000
alphabdiallo
alphabdiallo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor
@alphabdiallo alphabdiallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etal etal merged commit d77653d into main Oct 16, 2024
3 checks passed
@etal etal deleted the fix-dockerci branch October 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alphabdiallo alphabdiallo alphabdiallo approved these changes

@mcrocker-bioborg mcrocker-bioborg Awaiting requested review from mcrocker-bioborg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etal @alphabdiallo
0