8000 FIO-9905: Wrong behavior signature submitted data by yauheni-formio · Pull Request #1970 · formio/formio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIO-9905: Wrong behavior signature submitted data #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yauheni-formio
Copy link

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9905

Description

In the case of beforePut in signature, when we did not pass any signature field from UI, we automatically added it from the previous submission. I added a check for isNil to eliminate this behavior.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

I added unit test

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…ues is displayed in submitted data after editing a previously submitted form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0