Rename getPermittedSubtypes() to permittedSubclasses() to fix build #6

KengoTODA · 2021-04-24T01:10:07Z

Hi @forax,
thanks for your help at the core-libs-dev mailing list. It helped me to understand the record deeper. :)

When I compare your benchmark with mine, I found that the latest Travis build is broken:

src/main/java/fr.umlv.record/fr/umlv/sealed/NonSealedExample.java:14: error: cannot find symbol
		var permitted = I.class.getPermittedSubtypes();
		                       ^
  symbol:   method getPermittedSubtypes()
  location: variable class of type Class<I>

This is caused by an API change in Java 15; Java 15 uses Class#permittedSubclasses() instead of Class#getPermittedSubtypes().

note: I have no enough credit in Travis CI, so I haven't confirmed a successful build on Travis.
Instead, I confirmed it on GitHub Actions that uses this workflow definision.

Thanks again in advance!

https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/Class.html#permittedSubclasses()

KengoTODA · 2021-04-24T01:35:29Z

The build is still failing, because the nodejs is too old (probably v8) and the latest npm packages won't work with it.
I'll try to specify nodejs version for Travis CI.

/home/travis/build/forax/amber-record/node_modules/decktape/decktape.js:251
  } catch {
          ^
SyntaxError: Unexpected token {

fix: Java 15 uses permittedSubclasses() instead

ad52e59

https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/Class.html#permittedSubclasses()

KengoTODA added 3 commits April 24, 2021 09:37

ci: try to specify nodejs version

8d3e2a3

ci: try to specify nodejs version

a67e4f6

ci: try to specify nodejs version

63db0a9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename getPermittedSubtypes() to permittedSubclasses() to fix build #6

Rename getPermittedSubtypes() to permittedSubclasses() to fix build #6

Rename getPermittedSubtypes() to permittedSubclasses() to fix build #6

Are you sure you want to change the base?

Rename getPermittedSubtypes() to permittedSubclasses() to fix build #6

Conversation