Add Python 3.12 compatibility for path fieldtype #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 80.08% 80.12% +0.03%
==========================================
Files 33 33
Lines 3113 3119 +6
==========================================
+ Hits 2493 2499 +6
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tests/test_fieldtypes.py
Outdated
| if PY_312: | ||
| # Starting from Python 3.12, pathlib._Flavours are removed as you can now properly subclass pathlib.Path | ||
| # See also: https://github.com/python/cpython/issues/88302 | ||
| PosixFlavour = pathlib.PurePosixPath |
There was a problem hiding this comment.
The _flavour property in 3.12 is a link to the posixpath or ntpath module. We could do something similar by having a function def custom_flavour(sep, altsep) that yields a patch()ed posixpath with the given separator and alt separator and modify PureCustomPath like:
class PureCustomPath(pathlib.PurePath):
if PY_312:
_flavour = custom_flavour(sep, altsep)
else:
_flavour = CustomFlavour()
Our tests however just need a PurePath subclass instance with a _flavour property that has sep and altsep properties, so a simpler setup would for this case also work.
There was a problem hiding this comment.
i'm happy to accept any code suggestions
There was a problem hiding this comment.
I'd say, just do
| PosixFlavour = pathlib.PurePosixPath | |
| PosixFlavour = Mock |
as we probably don't want to really mock posixpath and now it is still clear that flavour is something different.
There was a problem hiding this comment.
This change gives me an error:
.tox/py3/lib/python3.12/site-packages/_pytest/assertion/rewrite.py:178: in exec_module exec(co, module.__dict__) tests/test_fieldtypes.py:558: in <module> (custom_pure_path(sep="/", altsep="")("/foo/bar"), True), tests/test_fieldtypes.py:547: in custom_pure_path class PureCustomPath(pathlib.PurePath): tests/test_fieldtypes.py:548: in PureCustomPath _flavour = CustomFlavour() tests/test_fieldtypes.py:543: in __new__ instance.sep = sep /usr/local/lib/python3.12/unittest/mock.py:771: in __setattr__ elif (self._spec_set and self._mock_methods is not None and /usr/local/lib/python3.12/unittest/mock.py:656: in __getattr__ elif self._mock_methods is not None: /usr/local/lib/python3.12/unittest/mock.py:655: in __getattr__ raise AttributeError(name) E AttributeError: _mock_methods
ab7f7e8 to
da57231
Compare
|
I had this change in mind. It's not a real mock of |
6fb4f36 to
7e2966f
Compare
|
Ok, this didn't work as expected, I'll have to look a bit more into it |
453930b to
34aa18f
Compare
any luck with this? |
|
I've pushed a possible fix for the unit test. |
|
Yes, that is the mock I was looking for 😉 |
f99737c to
688803a
Compare
Fixes #89