Fixes for data directives #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the following program: push.16 0 data.16 0 ... crashed fox32asm: thread 'main' panicked at 'internal error: entered unreachable code', src/main.rs:620:22 stack backtrace: 0: rust_begin_unwind at /usr/src/rustc-1.63.0/library/std/src/panicking.rs:584:5 1: core::panicking::panic_fmt at /usr/src/rustc-1.63.0/library/core/src/panicking.rs:142:14 2: core::panicking::panic at /usr/src/rustc-1.63.0/library/core/src/panicking.rs:48:5 3: fox32asm::parse_data 4: fox32asm::build_ast_from_expression 5: fox32asm::main note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. The issue in line 620 is that parse_data expects a constant in the form of AstNode::Immediate32, but finds an AstNode::Immediate16, because CURRENT_SIZE was previously set to Half. Set CURRENT_SIZE to Word when starting to parse a new data directive, in order to fix this issue. Fixes fox32-arch#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the two issues that are currently open.