Better error handling and nop.8 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
fox32asm 0.3.0 (94dd0fe)
Generating raw binary
Parsing includes...
Parsing file...
thread 'main' panicked at 'parse was unsuccessful: Error { variant: ParsingError { positives: [EOI, origin, include_bin, data, constant, label_kind, size, instruction], negatives: [] }, location: Pos(4), line_col: Pos((1, 5)), path: None, line: "nop 42␊", continued_line: None }', src/main.rs:529:60
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
After:
fox32asm 0.3.0 (2abba95)
Generating raw binary
Parsing includes...
Parsing file...
Error {
variant: ParsingError {
positives: [
EOI,
origin,
include_bin,
data,
constant,
label_kind,
size,
instruction,
],
negatives: [],
},
location: Pos(
4,
),
line_col: Pos(
(
1,
5,
),
),
path: None,
line: "nop 42␊",
continued_line: None,
}
nop.8 exists and is valid, so fox32asm should assemble it. It might be a good idea to reject some invalid instructions, though, such as out.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.