8000 Submission Review (grading) with multiple metrics by elad-eyal · Pull Request #557 · frab/frab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Submission Review (grading) with multiple metrics #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2019
Merged

Submission Review (grading) with multiple metrics #557

merged 8 commits into from
Oct 29, 2019

Conversation

elad-eyal
Copy link
Collaborator

see #518

@elad-eyal elad-eyal force-pushed the review-metrics-v4 branch 6 times, most recently from 88d8401 to 84eeaa4 Compare September 27, 2019 14:06
@elad-eyal elad-eyal mentioned this pull request Sep 27, 2019
Closed
@elad-eyal
Copy link
Collaborator Author

Added test for editing an event score's and checking that the average is calculated correctly.

@elad-eyal elad-eyal force-pushed the review-metrics-v4 branch 5 times, most recently from 8250016 to e1e9686 Compare October 2, 2019 17:53
@elad-eyal elad-eyal force-pushed the review-metrics-v4 branch 5 times, most recently from 65d211f to 347cbe3 Compare October 10, 2019 15:15
@elad-eyal elad-eyal mentioned this pull request Oct 13, 2019
Closed
@erdgeist
Copy link
Contributor

There's a lot going on in this PR that doesn't have to do with review metrics, like introduction of the assistant role and the concept of stakeholders. This makes it quite hard to review the review metrics part.

Since I am not sure how this is supposed to work, anyway, I focussed on anything BUT the review metrics and this looks okay.

@elad-eyal
Copy link
Collaborator Author

@erdgeist - I updated #518 to show better what "review metrics" are supposed to do.

@elad-eyal elad-eyal force-pushed the review-metrics-v4 branch 2 times, most recently from 6677cc0 to bddd5f1 Compare October 17, 2019 20:37
@elad-eyal
Copy link
Collaborator Author
  • Changes the settings tab to be called "Reviewing" and not "Review Metrics". Updated submission grading with multiple metrics #518 accordingly.
  • Simplified ReviewMetric::safe_name so now it has a default value for names only included non-latin characters.

@elad-eyal elad-eyal mentioned this pull request Oct 25, 2019
Merged
@elad-eyal
Copy link
Collaborator Author

rebased on master. Now this PR onl 8000 y includes relevant stuff

@elad-eyal elad-eyal changed the title submission grading with multiple metrics Submission Review (grading) with multiple metrics Oct 27, 2019
@elad-eyal elad-eyal mentioned this pull request Oct 27, 2019
Merged
erdgeist
erdgeist reviewed Oct 28, 2019
View reviewed changes
erdgeist
erdgeist reviewed Oct 28, 2019
View reviewed changes
app/views/event_ratings/show.html.haml
= f.simple_fields_for :review_scores do |ff|
= ff.input :score,
as: :radio_buttons,
collection: [[t('events_module.not_applicable'), '0'], ['1', '1'], ['2', '2'], ['3', '3'], ['4', '4'], ['5', '5']],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the zero value mean that you can undo a rating?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The value 0 is displayed as N/A when rating; and as a "blank" when looking at the rating summary. It does not taken account when calculating average review.

image

@erdgeist
Copy link
Contributor

I understand most of the PR now and see little changes that have the potential not be corrected easily if they contain mistakes I have not spotted.

I wonder how good the interface will actually work in the event reviews pane, but these may also be patched up later.

So from me that would be a go. Maybe @manno wants to comment, if not I'll merge after 24h.

@elad-eyal
Copy link
Collaborator Author

#614 is this pull + a modification to add_fake_data to create fake reviews, if you want to experiment with the GUI

@elad-eyal elad-eyal closed this Oct 28, 2019
@elad-eyal elad-eyal reopened this Oct 28, 2019
@elad-eyal
can save partial reviews
c7758a8 
Prior to this change, it was not possible to save an event rating
comment without specifying an event rating. This changes this
so reviewer can now save the comment text and return later to
complete the review. The event_rating counter will only count
events with an event rating specified. "Start review" flow (where
reviewer is presented with a series of events to review) also only
considers a review with a rating as a complete review.
@elad-eyal
Add "review metrics" per conference
66b1ec0
@elad-eyal
add review_score; allow editing review_score
38f42f1
@elad-eyal
show event_scores in "all_ratings" table
74aa79e
@elad-eyal
add review averages and display in event_rating screen
7ac9cd7
@elad-eyal
sort by average review score
c588029
@elad-eyal
add test for review metrics
9cb43fc
@elad-eyal
update schema.rb
a7f3986
@erdgeist erdgeist merged commit 171c18d into frab:master Oct 29, 2019
@elad-eyal elad-eyal mentioned this pull request Oct 30, 2019
Closed
@pcfe pcfe mentioned this pull request Nov 10, 2019
Closed
@elad-eyal elad-eyal deleted the review-metrics-v4 branch December 20, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdgeist erdgeist erdgeist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elad-eyal @erdgeist
0