8000 support ruby 2.7 by elad-eyal · Pull Request #690 · frab/frab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support ruby 2.7 #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2020
Merged

support ruby 2.7 #690

merged 4 commits into from
Feb 15, 2020

Conversation

elad-eyal
Copy link
Collaborator
@elad-eyal elad-eyal commented Jan 31, 2020 •
edited
Loading
  • add ruby 2.7 to travis CI
  • update bundler since bundler 1 is removed from ruby 2.7
  • add gem scanf because scanf is no longer bundled gem (link)
  • limit version of sass-rails because v6 requires manifest.js and I'm not sure how to build it.
  • bumped version (bundle update) because there were lots of deprecation warnings. There are less warnings now, bu there are still quite a few packages with warnings.
  • fix some depracation warnings in frab

Closes #688

Notes:

  1. sass-rails now notifies that sass is EOL . When we update sass-rails to v6, it will update to sassc

  2. There are a few warnings on frab code:

app/lib/static_schedule/export.rb:83: warning: URI.unescape is obsolete
app/lib/static_schedule/export.rb:104: warning: URI.unescape is obsolete

@elad-eyal elad-eyal requested a review from manno January 31, 2020 20:34
@elad-eyal elad-eyal mentioned this pull request Jan 31, 2020
Closed
@elad-eyal elad-eyal closed this Feb 1, 2020
@elad-eyal elad-eyal reopened this Feb 1, 2020
@elad-eyal elad-eyal closed this Feb 1, 2020
@elad-eyal elad-eyal reopened this Feb 1, 2020
@elad-eyal elad-eyal requested a review from erdgeist February 2, 2020 10:55
@elad-eyal elad-eyal mentioned this pull request Feb 10, 2020
Closed
@elad-eyal
force sass-rails version; bump gems
26b8daa
@elad-eyal
fix deprecation warnings
fb0055e 
app/lib/static_schedule/export.rb:73: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
@erdgeist erdgeist merged commit 0ebfe61 into frab:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manno manno Awaiting requested review from manno

@erdgeist erdgeist Awaiting requested review from erdgeist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker build is broken (ruby 2.7.0)
2 participants
@elad-eyal @erdgeist
0