8000 allow review metrics starting with digit by elad-eyal · Pull Request #629 · frab/frab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

allow review metrics starting with digit #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elad-eyal
Copy link
Collaborator

Before this change, a review metric starting with a digit will
convert to an sql term starting with a digit, which is not
acceptable SQL.

Before this change, a review metric starting with a digit will
convert to an sql term starting with a digit, which is not
acceptable SQL.
@erdgeist erdgeist merged commit 1a393ad into frab:master Nov 3, 2019
@elad-eyal elad-eyal deleted the fix_review_metric_name_starting_with_digit branch December 20, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0