10000 fix exception on empty update; simplify coffeescript by elad-eyal · Pull Request #749 · frab/frab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix exception on empty update; simplify coffeescript #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2020
Merged

fix exception on empty update; simplify coffeescript #749

merged 3 commits into from
Nov 28, 2020

Conversation

elad-eyal
Copy link
Collaborator

closes #516

@elad-eyal
simplify CoffeeScript
99eaa38 
These changes are prevent Capybara reporting JS errors
@elad-eyal
fix exception when submitting empty update
d4c9743 
Closes frab#516
@elad-eyal elad-eyal force-pushed the fix_516 branch 2 times, most recently from b5b2b01 to d4c9743 Compare November 14, 2020 11:48
@elad-eyal elad-eyal requested a review from saerdnaer November 14, 2020 16:22
saerdnaer
saerdnaer approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor
@saerdnaer saerdnaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elad-eyal elad-eyal merged commit 4c645ff into frab:master Nov 28, 2020
@elad-eyal elad-eyal deleted the 6B50 fix_516 branch November 28, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saerdnaer saerdnaer saerdnaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exception when not-updating empty classifier list
2 participants
@elad-eyal @saerdnaer
0