8000 fix filter by blank string by elad-eyal · Pull Request #709 · frab/frab · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix filter by blank string #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix filter by blank string #709

merged 2 commits into from
Oct 8, 2020

Conversation

elad-eyal
Copy link
Collaborator

This PR fixes a bug from #579.

To reproduce the bug: Create two events. 1 with track field empty and 1 with track field populated. Open All Events. Click the filter item next to Track. Check V next to "(blank)", hit OK. It will not filter correctly.

So this fixes it.

@elad-eyal elad-eyal force-pushed the fix_blank_filter branch 2 times, most recently from 34067b4 to 2761839 Compare July 15, 2020 16:30
@elad-eyal
Copy link
Collaborator Author

@erdgeist would you like to review this?

@elad-eyal
Copy link
Collaborator Author

@manno would you like to review this?

@elad-eyal
Copy link
Collaborator Author

@manno

@elad-eyal
Copy link
Collaborator Author

@erdgeist ?

@elad-eyal elad-eyal merged commit d474a5a into frab:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saerdnaer saerdnaer saerdnaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elad-eyal @saerdnaer
0