feat: sqlite fts based search #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiki
|
|||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Wiki
|
| Branch Review |
sqlite-fts
|
| Run status |
|
| Run duration | 01m 21s |
| Commit |
|
| Committer | Alan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
5
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
wiki.cy.js • 3 failed tests
| Test | Artifacts | |
|---|---|---|
| Wiki > creates a new wiki page |
Test Replay
Screenshots
|
|
| Wiki > edits a wiki page |
Test Replay
Screenshots
|
|
| Wiki > deletes a wiki page |
Test Replay
Screenshots
|
|
wiki_sidebar.cy.js • 2 failed tests
| Test | Artifacts | |
|---|---|---|
| Wiki Sidebar > creates a new wiki sidebar group |
Screenshots
|
|
| Wiki Sidebar > deletes a wiki sidebar group when the group is empty |
Screenshots
|
|
|
cypress tests have failed cause of timeouts. linter appears to have failed cause of files untouched in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i needed a playground (in prod) for some search ideas i need for another project i'm working on. search is based on SQLite FTS5 cause it serves as a decent stepping board. added some minor reranking over returned results.
baseline has better (anecdotal) results compared to existing (redis based) search. added minor ux improvements (reduced debounce).