8000 feat: Add 'Leave' status in Student Attendance DocType by RitvikSardana · Pull Request #256 · frappe/education · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add 'Leave' status in Student Attendance DocType #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2024
Merged

feat: Add 'Leave' status in Student Attendance DocType #256

merged 7 commits into from
May 23, 2024

Conversation

RitvikSardana
Copy link
Member
@RitvikSardana RitvikSardana commented May 23, 2024 •
edited
Loading

Issue:
As of now only two status are present in the "Student Attendance" DocType, which are Present/Absent. When a student applies for leave via "Student Leave Application" DocType the status of them is marked as "Absent" but in a lot of educational institutes "Leave" Status is to be filled if the student applies for leave.

Solution:
This PR adds the status of "Leave" in the "Student Attendance DocType".
So now when a student applies for Leave, their status will be marked as "Leave" instead of "Absent".

What Changed:

  1. Leave status in "Student Attendance" DocType
  2. Reports "Student Monthly Attendance Sheet" & "Student Batch Wise Attendance" now supports attendance with "Leave" status. These were written in old format so re-wrote it in new format of reports
  3. Student Portal supports attendance with "Leave" status.
  4. Fixes issue in student portal where only one attendance was marked when "attendance_based_on_course_schedule" was disabled in the Education Settings.
  5. Instructors will be able to edit the attendance status even after submitting the document.
  6. add doc_states via Document States child table instead of using "get_indicator" method

@RitvikSardana RitvikSardana merged commit 8ce379e into frappe:develop May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Education Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RitvikSardana
0