8000 perf: Don't query redirects on existing session by ankush · Pull Request #28981 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf: Don't query redirects on existing session #28981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

ankush
Copy link
Member
@ankush ankush commented Jan 1, 2025

This is only used for a new user. After that it's never used but still present in EVERY request!

Note: This isn't typical "redirect after login" that's handled by the URL itself. This is used when a user visits a page and is asked to sign up first.

https://ankush.dev/p/flamegraph-missing-forest-for-trees

towards frappe/caffeine#15

This is only used for a new user. After that it's never used but still
present in EVERY request!

https://ankush.dev/p/flamegraph-missing-forest-for-trees

towards frappe/caffeine#15
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Jan 1, 2025
@ankush ankush marked this pull request as draft January 1, 2025 09:02
@ankush ankush marked this pull request as ready for review January 1, 2025 09:09
@ankush ankush enabled auto-merge January 1, 2025 09:14
@ankush ankush merged commit 6989e50 into frappe:develop Jan 1, 2025
25 checks passed
@ankush ankush deleted the perf/redirect_call branch January 1, 2025 09:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2025
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0