refactor: Enhance About dialog box
#28994
Open
+153
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove readability
…copy functionality
This comment was marked as outdated.
8000
Sign in to view
This comment was marked as outdated.
8000
Sign in to view
|
@Abdeali099 are you still working on this or is it ready for review? |
No, I am working. Need to change the format of copied apps json |
This comment was marked as outdated.
This comment was marked as outdated.
3c563c1 to
118e3ca
Compare
|
What if use data-table?
|
barredterra
reviewed
May 23, 2025
Comment on lines
+26
to
+30
| <p> | ||
| <i class='fa fa-graduation-cap fa-fw'></i> | ||
| ${__("Frappe School")}: | ||
| <a href='https://frappe.school' target='_blank'>https://frappe.school</a> | ||
| </p> |
There was a problem hiding this comment.
Not sure if this counts as a social link and is relevant for users of framework based apps.
There was a problem hiding this comment.
should keep or remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
User perspective
Forum,BlogandInstagramlinkYouTubelogoCopy to clipboardbutton to copy installed app informationDeveloper perspective
varwithconstorletaccordinglyrepl,frappe.app,sortAll Apps Version Copy Sample Text
{ "frappe": "16.0.0-dev", "erpnext": "16.0.0-dev", "india_compliance": "16.0.0-dev" }Single App Version Copy Sample Text
See About dialog box changes
Before:
After:
Demo
About.Dialog.version.Copy.mp4
Note
Change
Twitterlogo with its new logoXwithSVGbecause new logo is not available in font-awsome4.7.0versionImportant
Backport to v-15 and v-14