fix: prevent logout due to empty "Password" field #29158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We don't want get decrypted password to raise a ValidationError - If api_key, api_secret or doc_secret are empty, we want an AuthenticationError
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume you have a single doctype with an empty password field.
The user clicks a button that triggers a backend method, which in turn tries to read the password:
Desired effect
The user sees an error message that says the password is missing and can go ahead with fixing that.
Observed effect
User gets logged out.
If no password was found, we used to raise an
AuthenticationError. If the error is not caught, we clear the cookies:frappe/frappe/app.py
Lines 389 to 391 in c72e91f
Proposed fix
Raise a
ValidationErrorinstead of anAuthenticationError.get_password/get_decrypted_passwordare data retrieval utilities, not authentication functions. They should raiseValidationErrorfor:The calling code can then decide the appropriate response:
AuthenticationErrorTodo