8000 fix(print): handle custom format with custom module (backport #31372) by mergify[bot] · Pull Request #31376 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(print): handle custom format with custom module (backport #31372) #31376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix(print): handle custom format with custom module (backport #31372) #31376

merged 1 commit into from
Feb 21, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Feb 21, 2025

The Problem

  • Create a custom doctype in a custom module

  • Create a print format for that doctype with "custom_format" checked (enabled Jinja/HTML field)

  • Try to print:

    CleanShot 2025-02-21 at 13 03 08@2x

Reason

This happens because the code does not handle this case and tries to look for the template in the file system.

The Solution

Do not try to look for a file if the module is custom.

Co-authored-by: Aman amanupadhayay2906@gmail.com
Co-authored-by: Khushbu mittalk1802@gmail.com
Co-authored-by: Manya girdharmanya28@gmail.com
Co-authored-by: Ritika ritika@korecent.com
Co-authored-by: Siddharth siddharth.khati03@gmail.com
Co-authored-by: Yashvi yashvi@korecent.com

This is an automatic backport of pull request #31372 done by [Mergify](https://mergify.com).

@NagariaHussain @maskeddefender
@Khushbu1824 @ManyaGirdhar @ritikaaguptaa @Siddharthkhati @YashviiSharma @mergify
fix(print): handle custom format with custom module
1347897 
Co-authored-by: Aman <amanupadhayay2906@gmail.com>
Co-authored-by: Khushbu <mittalk1802@gmail.com>
Co-authored-by: Manya <girdharmanya28@gmail.com>
Co-authored-by: Ritika <ritika@korecent.com>
Co-authored-by: Siddharth <siddharth.khati03@gmail.com>
Co-authored-by: Yashvi <yashvi@korecent.com>
(cherry picked from commit 4f453f2)
@iamejaaz iamejaaz enabled auto-merge February 21, 2025 09:23
@iamejaaz iamejaaz merged commit 6557773 into version-15-hotfix Feb 21, 2025
15 of 16 checks passed
@iamejaaz iamejaaz deleted the mergify/bp/version-15-hotfix/pr-31372 branch February 21, 2025 09:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@NagariaHussain NagariaHussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NagariaHussain @iamejaaz
0