8000 fix: confirm before removing attachment on clear button in attach control by prateekkaramchandani · Pull Request #31388 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: confirm before removing attachment on clear button in attach control #31388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

prateekkaramchandani
Copy link
Contributor

This PR adds a confirmation prompt before removing an attachment when clicking the clear button in the attach control. This ensures users don’t accidentally delete attachments without confirmation.

screencast.webm

@iamejaaz iamejaaz self-assigned this Mar 14, 2025
Copy link
Member
@iamejaaz iamejaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iamejaaz iamejaaz added the backport version-15-hotfix Backport the PR to v15 label Mar 14, 2025
@iamejaaz iamejaaz merged commit 2043255 into frappe:develop Mar 14, 2025
24 checks passed
iamejaaz added a commit that referenced this pull request Mar 14, 2025
…-31388

fix: confirm before removing attachment on clear button in attach control (backport #31388)
@rehansari26
Copy link
Contributor

@prateekkaramchandani 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0