perf(doc): skip order_by when name is set in load_from_db (backport #18837) #31452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting ORDER BY clause in the SQL nudges MariaDB to not use index (even) for primary keys. (cherry picked from commit 9ad0538) # Conflicts: # frappe/model/document.py
|
Cherry-pick of 9ad0538 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
## [14.94.2](v14.94.1...v14.94.2) (2025-03-04) ### Bug Fixes * check for running jobs before migrating (backport [#31438](#31438)) ([#31439](#31439)) ([c937328](c937328)) * check types explicitly ([b1be1d4](b1be1d4)) * ensure consistent error in response ([3b8c976](3b8c976)) * ensure correct context in `sys.exc_info` ([3000e66](3000e66)) * ensure exception is always returned ([17a318a](17a318a)) * Ensure that scheduled jobs don't start in maintenance_mode ([#31450](#31450)) ([#31455](#31455)) ([466a646](466a646)) * explicitly check type of form name ([21f7b33](21f7b33)) * fetch data from submitted child rows for global search indexing ([#31405](#31405)) ([#31406](#31406)) ([660be20](660be20)) * handle large URL on webhook logs (backport [#31428](#31428)) ([#31429](#31429)) ([c5e7e51](c5e7e51)) * ignore `disable_traceback` if `_dev_server` is True ([956af31](956af31)) * merge conflict ([ec77e5c](ec77e5c)) * merge conflicts ([fdcd4be](fdcd4be)) * **print:** handle custom format with custom module ([5ed9a3e](5ed9a3e)) * redo some fixes to ensure cypress passes (backport [#31334](#31334)) ([b7224b9](b7224b9)) * remove dev server condition ([c1bea8b](c1bea8b)) * remove flag to ensure some checks run ([4ee4708](4ee4708)) * remove merge conflict ([63f3e4a](63f3e4a)) * **send_message:** escape HTML in the text ([50bbf7e](50bbf7e)) * set login_id for sengrid ([c832259](c832259)) * template error on custom print format ([7f6948d](7f6948d)) * Update phonenumber library to handle new GY phone number format (backport [#31328](#31328)) ([#31342](#31342)) ([2386a8a](2386a8a)) * update type hints to allow integers ([8ad02b2](8ad02b2)) * update whitelisted methods ([997ff9b](997ff9b)) * **workflow_action:** Pass context as dict to render template ([49621bb](49621bb)) ### Performance Improvements * Add prefix index for file_url ([#29185](#29185)) ([#31403](#31403)) ([d2ad3de](d2ad3de)) * cast int-link field filters to string ([#31396](#31396)) ([#31397](#31397)) ([dbb2645](dbb2645)) * **doc:** skip order_by when name is set in load_from_db (backport [#18837](#18837)) ([#31452](#31452)) ([1f39f8e](1f39f8e)) * skip order by for open_count ([#31472](#31472)) ([#31480](#31480)) ([5a2ad66](5a2ad66)) * workspace cache thrashing (backport [#31446](#31446)) ([#31449](#31449)) ([4f39405](4f39405))
|
🎉 This PR is included in version 14.94.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting ORDER BY clause in the SQL nudges MariaDB to not use index (even) for primary keys.
This is an automatic backport of pull request #18837 done by [Mergify](https://mergify.com).