refactor: Allow isolated headlines/intros in the form (backport #31459) #31493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: Allow isolated headlines/intros in the form - Each attempt to `show_message` should be rendered as a separate block with its own color and close button - When grouped together the point of passing individual colors is lost - The grouping behaviour also seemed implicit. - An independently set headline could never stand out and the message is lost when grouped with another headline * fix: Pull docstring out + avoid deprecated "substr" + Border Bottom * chore: Add color options for color param in `show_message` docstring Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> --------- Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> (cherry picked from commit 2022ddf) # Conflicts: # frappe/public/js/frappe/form/layout.js
This comment was marked as resolved.
This comment was marked as resolved.
- chore: Also remove `border-bottom` and reduce margin-bottom due to v15's design
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
show_messagegroups all headlines passed to it and assumes the state of the last headlineYet they are grouped -> the intent is completely ignored -> the outcome isn't what was expected
An independently set headline can't stand out and the message is lost when grouped with another headline
Proposed Fix
Each attempt to
show_messageshould be rendered as a separate block with its own color and close buttonRemoval affects the right headline
Headlines with HTML passed
Restructure:
.form-message-containercontains.form-messageblocksThis is an automatic backport of pull request #31459 done by [Mergify](https://mergify.com).