refactor: sign up flow changes (backport #31205) #31494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: logout to site login page if the site is on Frappe Cloud * fix: check if the site user is logged in before rendering trial banner * fix: show dropdown even if the site is not on trial plan * refactor: don't expose communication secret in boot * feat: show install app button for fc sites * fix: remove auth from desk we can simplify it and let user do auth in fc * fix: install app button condition * refactor: use `is_fc_site` method * fix: return boolean value for `is_fc_site` function * fix: add install app button in /apps page * fix: don't generate otp for login to fc * fix: remove install app option from desk * fix: design changes for trial banner * fix: add more details to the `current_site_info` endpoint also don't render trial banner if trial end date is passed * fix: don't route user to welcome page always put them on the site's dashboard * fix: override base_url when needed also remove misleading class * fix: show banner to normal user to contact system admin for plan upgrade * refactor: redirect from /login instead of every /logout code * fix: rename login to fc to manage billing also move it above the divider * refactor: separate out site-login url from login.py (cherry picked from commit 5886234) # Conflicts: # frappe/website/utils.py
|
Cherry-pick of 5886234 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
BreadGenie
reviewed
Mar 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't do auth from desk
trial banner changes
if the site is on fc logout to fc /site-login page
This is an automatic backport of pull request refactor: sign up flow changes #31205 done by Mergify.