8000 fix(report): show add_total_row checkbox if report_type is not 'Repor… (backport #31681) by mergify[bot] · Pull Request #31683 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(report): show add_total_row checkbox if report_type is not 'Repor… (backport #31681) #31683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix(report): show add_total_row checkbox if report_type is not 'Repor… (backport #31681) #31683

merged 1 commit into from
Mar 17, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Mar 12, 2025

Report Builder doesn't use add_total_row anyway, it is redundant to show it in the UI anyway

This is an automatic backport of pull request #31681 done by Mergify.

@mergify mergify bot added the conflicts label Mar 12, 2025
@mergify Mergify
Copy link
Contributor Author
mergify bot commented Mar 12, 2025

Cherry-pick of 41b331d has failed:

On branch mergify/bp/version-14-hotfix/pr-31681
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 41b331d856.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/core/doctype/report/report.json

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@tarunps tarunps force-pushed the mergify/bp/version-14-hotfix/pr-31681 branch from bc08a47 to 79198bf Compare March 13, 2025 06:37
@tarunps tarunps removed the conflicts label Mar 13, 2025
@tarunps tarunps merged commit a58dc9d into version-14-hotfix Mar 17, 2025
9 of 10 checks passed
@tarunps tarunps deleted the mergify/bp/version-14-hotfix/pr-31681 branch March 17, 2025 05:01
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.95.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tarunps tarunps

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frappe-pr-bot @tarunps
0