fix: always persist all indexes added via db.add_index (backport #31177) #31712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: always persist all indexes added via db.add_index * fix: Add `if not exists` clause for index creation This allows replica to have same index and master to add it later without causing SQL error. Just minor DX benefit. * fix(postgres): don't cache if table doesn't exist * chore: revert postgres changes Hopeless to maintain this (cherry picked from commit 573028a)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
# [15.59.0](v15.58.1...v15.59.0) (2025-03-18) ### Bug Fixes * always persist all indexes added via db.add_index ([#31177](#31177)) ([#31712](#31712)) ([243aedd](243aedd)) * avoid overriding saved list filters ([#31699](#31699)) ([#31702](#31702)) ([7a2d447](7a2d447)) * **awesomebar:** sanitise text when searching in list views ([11036f8](11036f8)) * confirm before removing attachment on clear button in attach control ([9ce73e3](9ce73e3)) * don't generate type information for virtual fields ([#31592](#31592)) ([72c7635](72c7635)) * Encode filters to handle special characters ([39d2d53](39d2d53)) * give prority to user setting on sorting ([fe4286d](fe4286d)) * increase length for value field in sms parameter (backport [#31692](#31692)) ([#31695](#31695)) ([93659d4](93659d4)) * Kanban view link draggable issue ([90d5e75](90d5e75)) * **mariadb:** set collation in connection (backport [#31523](#31523)) ([#31766](#31766)) ([e81b912](e81b912)) * Merge conflicts ([47a1a84](47a1a84)) * option to opt out of automatic filters (backport [#31678](#31678)) ([#31680](#31680)) ([1aded5e](1aded5e)) * report header not translated ([7cbd9c5](7cbd9c5)) * **report:** show add_total_row checkbox if report_type is not 'Report Builder' ([4b17a84](4b17a84)) * resolve conflicts ([85ed247](85ed247)) * return 1 or 0 instead of boolean for `is_fc_site` boot data ([#31753](#31753)) ([#31754](#31754)) ([3129e61](3129e61)) * Round of rate limit to seconds ([#31674](#31674)) ([#31686](#31686)) ([0d2ab34](0d2ab34)) * support "Timespan" in `evaluate_filters` ([#31190](#31190)) ([#31709](#31709)) ([0e50235](0e50235)) * sync translations from crowdin ([#31659](#31659)) ([17617fa](17617fa)) * Translate link fields in Webform ([c7dc6c0](c7dc6c0)) * Translate names if "Translate Link Fields" is enabled ([cd6b821](cd6b821)) * Use DOMParser in `is_html` + Handle unparsable html string with jquery ([a4bae9b](a4bae9b)) * Use jQuery.text() instead of xss_sanitise ([603441a](603441a)) * **user:** make attachments in email signature public ([#31752](#31752)) ([8a94bbe](8a94bbe)) * **user:** stricter name validation (backport [#31679](#31679)) ([#31701](#31701)) ([a12de55](a12de55)) * **UX:** Show reason for read only form in headline ([6129eb7](6129eb7)) ### Features * show helpdesk and crm banner on sidebar ([7441dd6](7441dd6)) ### Performance Improvements * `doc.permitted_fieldnames` is now a set ([0af6946](0af6946)) * generate auto email reports in background ([f7798a0](f7798a0)) * improve `get_permitted_fields` logic ([e681195](e681195)) * remove repeated calls to `get_permitted_fieldnames` ([ad9aafa](ad9aafa)) ### Reverts * "fix(UX): Show reason for read only form in headline ([#31511](#31511))" (backport [#31669](#31669)) ([1a16a2b](1a16a2b))
|
🎉 This PR is included in version 15.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've wasted tremendous amount of time trying to get people to not manually add
them, but it's waste of time trying to change the world. Paying cost of few
unused index is less than wasting time re-adding them.
This is an automatic backport of pull request #31177 done by [Mergify](https://mergify.com).