8000 fix: print <ol> numbering by Rl0007 · Pull Request #33036 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: print <ol> numbering #33036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2025
Merged

fix: print <ol> numbering #33036

merged 2 commits into from
Jun 21, 2025
+4 −0

Conversation

Rl0007
Copy link
Contributor
@Rl0007 Rl0007 commented Jun 21, 2025 •
edited
Loading
  • Removes global counter for ql-editor. This is necessary because wkhtmltopdf does not support JS (this is why it works in Editor UI and not generated PDF)

Before

Screenshot 2025-06-21 at 1 52 56 PM

After

Screenshot 2025-06-21 at 1 53 15 PM

Support Ticket: https://support.frappe.io/helpdesk/tickets/41053

@NagariaHussain NagariaHussain requested a review from Copilot June 21, 2025 09:32
Copilot
Copilot AI reviewed Jun 21, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes

    numbering conflicts in printed documents by removing the global counter for the ql-editor.

    • Removes the global counter for
        elements within .ql-editor in the print stylesheet
      1. Adds a clarifying comment to explain the change
    Comments suppressed due to low confidence (1)

    frappe/public/scss/print.bundle.scss:56

    • Verify that using 'counter-reset: none;' achieves the intended effect across all target environments, including wkhtmltopdf. If any browser or tool-specific issues arise, consider adding vendor-specific fallbacks.
    	counter-reset: none;

@NagariaHussain NagariaHussain added the backport version-15-hotfix Backport the PR to v15 label Jun 21, 2025
@NagariaHussain NagariaHussain merged commit 899f2bc into frappe:develop Jun 21, 2025
24 checks passed
mergify bot pushed a commit that referenced this pull request Jun 21, 2025
@Rl0007 @mergify
fix: print <ol> numbering (#33036)
65e1da8 
* fix: print ol numbering

* fix: update comment

---------

Co-authored-by: Rahul Agrawal <deathstarconsole@Rahuls-MacBook-Air.local>
(cherry picked from commit 899f2bc)
@mergify mergify bot mentioned this pull request Jun 21, 2025
Merged
NagariaHussain pushed a commit that referenced this pull request Jun 21, 2025
@mergify @Rl0007
fix: print <ol> numbering (#33036) (#33041)
86906c4 
* fix: print ol numbering

* fix: update comment

---------


(cherry picked from commit 899f2bc)

Co-authored-by: Rahul Agrawal <12agrawalrahul@gmail.com>
Co-authored-by: Rahul Agrawal <deathstarconsole@Rahuls-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rl0007 @NagariaHussain
0