build: when building from a tag, verify the tag's signature and working tree #7478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
reviewed
Mar 21, 2025
39b532f to
bb730e5
Compare
…ng tree "git log --show-signature" verifies the signature on the tag's commit, not the tag itself. Either verification is enforced on history, not on the working tree actually being built from. Co-authored-by: Kunal Mehta <legoktm@debian.org>
bb730e5 to
ccad4dd
Compare
cfm
added a commit
to freedomofpress/securedrop-client
that referenced
this pull request
Apr 29, 2025
…g, and working tree Per freedomofpress/securedrop#7478.
1 task
legoktm
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
securedrop-apt-prod's pull-request template refers to checking thatbuild-logsdemonstrates that the intended tag was built. But that's not what we get from:securedrop/builder/build-debs.sh
Line 7 in dd90e52
git log --show-signatureverifies the signature on the tag's commit, not the tag itself, which still has to be verified manually withgit tag -v.This pull request explicitly verifies both (1) and (2).
Testing
Review along with freedomofpress/securedrop-client#2431.
2.12.0and runmake build-debs, and confirm that2.12.0is verified by tag rather than by commit.Deployment
No deployment considerations.