8000 test(`kernel-auto-test`): run and upload output from `test_grsecurity_local` test suite by cfm · Pull Request #7534 · freedomofpress/securedrop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test(kernel-auto-test): run and upload output from test_grsecurity_local test suite #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

cfm
Copy link
Member
@cfm cfm commented May 6, 2025

Status

Ready for review

Description of Changes

Closes #7527 by adding a third check to the kernel-testing sequence:

  1. Downloads the testinfra test suite (by cloning this repository).
  2. Creates and runs the test_grsecurity_local override test suite.
  3. Uploads the results as a third gist.

Testing

  1. Deploy to the kernel test machines.
  2. kernel-auto-test.py creates accurate gists and tickets for a kernel (e.g. New Linux kernel: 5.15.180-1-grsec-securedrop #7528) that fails the test_grsecurity suite.
  3. kernel-auto-test.py creates accurate gists and tickets for a kernel (pending from May kernel update #7511) that passes the test_grsecurity suite.

@cfm cfm self-assigned this May 6, 2025
@cfm cfm added this to SecureDrop May 6, 2025
@cfm cfm moved this to In Progress in SecureDrop May 6, 2025
---so that it doesn't have to be committed on "develop" at all, be run
or work around in CI, etc.
@cfm cfm moved this from In Progress to Ready For Review in SecureDrop May 7, 2025
@cfm cfm marked this pull request as ready for review May 7, 2025 20:44
@cfm cfm requested a review from a team as a code owner May 7, 2025 20:44
@cfm
Copy link
Member Author
cfm commented May 7, 2025

@legoktm suggested that I fold #7533 into kernel-auto-test.py itself, so that the test_grsecurity_local.py override suite doesn't have to run or be worked around in CI. That's done in 408d835. Since testing changes to the kernel-test branch requires direct access to the kernel-testing machines, @legoktm will do that tomorrow as I've outlined above.

@cfm cfm assigned legoktm and unassigned cfm May 7, 2025
@legoktm
Copy link
Member
legoktm commented May 8, 2025

I'll push some fixups in a minute; here's the log from a successful failed test run: https://gist.github.com/sdcibot/00436a4cb3f679a7105ed4a22ee48e3e

@legoktm
Copy link
Member
legoktm commented May 8, 2025

And it showing up in the auto-comment: #7529 (comment)

* Clone with --depth=1 for speed
* Invoke pytest without activating the venv
* Reinstall paxtest after the test removes it (TODO)
* Install more dependencies so we can get the virtualenv built
@legoktm legoktm force-pushed the 7527-kernel-test branch from 37175dd to 144810f Compare May 8, 2025 21:57
@legoktm legoktm merged commit 2bef790 into kernel-test May 8, 2025
26 of 42 checks passed
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in SecureDrop May 8, 2025
< 7AFD div data-view-component="true" class="TimelineItem-body"> @legoktm legoktm deleted the 7527-kernel-test branch May 8, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
0