Resolve daemon warnings for threading methods #7532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
|
Thanks for the PR @emmanuel-ferdman; I'm curious, did you see these warnings in the context of SecureDrop or elsewhere? |
|
Got it, I was just curious how you found them :) |
legoktm
reviewed
May 6, 2025
There was a problem hiding this comment.
Thanks! CI is happy (the test failure is somewhat expected), and I verified that this was supported back in 3.8 too: https://docs.python.org/3.8/library/threading.html#threading.Thread.daemon
legoktm
approved these changes
May 6, 2025
Merged
via the queue into
freedomofpress:develop
with commit May 6, 2025
7a3b4e1
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This small PR resolves the
threadingdeprecation warnings:It also fixes a few typos I came across along the way in the relevant files.
Testing
run tests and check for warnings.
Deployment
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following:
If you added or updated a reference to a production code dependency:
Documentation
For Rust code, dependency review is enforced by the cargo-vet CI job.
For Python code, production code dependencies are defined in:
admin/requirements.inadmin/requirements-ansible.insecuredrop/requirements/python3/requirements.insecuredrop/requirements/python3/translation.in(used in the buildcontainer)
If you changed another
requirements.infile that applies only to developmentor testing environments, then no diff review is required, and you can skip
(remove) this section.
Choose one of the following: