Add integration tests for nl2br jinja2 filter #7546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly verify the basic behavior of turning `\n` into `<br>` and then the escaping of HTML elements, so XSS isn't possible through it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Explicitly verify the basic behavior of turning
\ninto<br>and then the escaping of HTML elements, so XSS isn't possible through it.The test cases were originally written by Claude (transcript), I adjusted them to reuse our existing environment to make it more of a true integration test.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a