8000 fix: show info message for mark_runner_started / mark_runner_completed by ocervell · Pull Request #694 · freelabz/secator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: show info message for mark_runner_started / mark_runner_completed #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix: show info message for mark_runner_started / mark_runner_completed #694

merged 1 commit into from
Jun 11, 2025

Conversation

ocervell
Copy link
Contributor
@ocervell ocervell commented Jun 11, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Added informational console messages when runner tasks start or complete within a Celery worker process.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 11, 2025 •
edited
Loading

Walkthrough

Two conditional print statements were added to the mark_runner_started and mark_runner_completed Celery tasks. These statements output informational messages when running inside a Celery worker process, while the rest of the existing logic remains unchanged.

Changes

File(s) Change Summary
secator/celery.py Added conditional print statements to mark_runner_started and mark_runner_completed tasks.

Poem

The Celery runner hops with glee,
Now prints its state for all to see.
When tasks begin or reach their end,
A message from the worker, it will send.
Console chatter, clear and bright—
The rabbit logs each task’s delight!

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
secator/celery.py (1)

243-266: Consider extracting repeated console-print logic
Both mark_runner_started and mark_runner_completed perform the same conditional check and Info-print pattern. Factoring this into a helper would reduce duplication and improve readability. For example:

def _print_runner_event(runner, action: str, hook: str):
    if IN_CELERY_WORKER_PROCESS:
        console.print(Info(message=f'Runner {runner.unique_name} {action}, running {hook}'))

# Usage in mark_runner_started:
_print_runner_event(runner, 'has started', 'mark_started')

# Usage in mark_runner_completed:
_print_runner_event(runner, 'has finished', 'mark_completed')
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c406e34 and 589caf1.

📒 Files selected for processing (1)
  • secator/celery.py (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
secator/celery.py (1)
secator/output_types/info.py (1)
  • Info (8-24)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: integration (3.11, ubuntu-latest)
  • GitHub Check: Analyze (python)
🔇 Additional comments (2)
secator/celery.py (2)

243-244: Approve Info message for runner start in Celery worker
The Info message prints only when IN_CELERY_WORKER_PROCESS is True, which aligns with the PR objective and avoids polluting non-worker logs.

265-266: Approve Info message for runner completion in Celery worker
This addition gives real-time feedback inside the worker process without altering the existing task logic. Looks good.

@ocervell ocervell merged commit ed0f6cb into main Jun 11, 2025
10 checks passed
@ocervell ocervell mentioned this pull request Jun 11, 2025
Merged
ocervell added a commit that referenced this pull request Jun 11, 2025
@ocervell
chore(main): release 0.16.3 (#691)
a785306 
🤖 I have created a release *beep* *boop*
---


##
[0.16.3](v0.16.2...v0.16.3)
(2025-06-11)


### Bug Fixes

* bup file flag ([#690](#690))
([83d83d7](83d83d7))
* **celery:** add no_live_updates to skip backend updates
([#695](#695))
([c99599c](c99599c))
* **dalfox:** use jsonl option instead of json
([#692](#692))
([c406e34](c406e34))
* **mongodb:** add all output types
([#696](#696))
([af98935](af98935))
* show info message for mark_runner_started / mark_runner_completed
([#694](#694))
([ed0f6cb](ed0f6cb))
* **workflow:** put cariddi in crawlers group
([#693](#693))
([a9e1afd](a9e1afd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ocervell
0