Use market data to get base and quote currencies in @informative() decorator #5936
Conversation
508cec2 to
eab528f
Compare
| base = market['baseId'] | ||
| quote = market['quoteId'] |
There was a problem hiding this comment.
any particular reason to go with "baseId" instead of "base" (Which we are using already in the exchange class ...) ?
There was a problem hiding this comment.
I asked about these in the chat. I got a vague answer from you and/or @samgermain that some exchanges may set 'base' as 'Etherium' while having 'baseId' as 'ETH'. Though in that case it would make other freqtrade code using 'base'/'quote' invalid. So i went ahead and dug in ccxt source code.
const baseId = this.safeString (market, 'baseAssetName');
const quoteId = this.safeString (market, 'quoteAssetName');
const id = this.safeString (market, 'marketId');
const base = this.safeCurrencyCode (baseId);
const quote = this.safeCurrencyCode (quoteId);Seems like baseId is often source of base string. I think i can change it to using base/quote then.
There was a problem hiding this comment.
You should use base and quote
eab528f to
78a00f2
Compare
|
Does this mean that this task is done?
|
leave it open for now please - i'll need to think about it a bit more what it'll mean for that decorator if we have |
This does make exchange non-optional when using decorators though.. Should we do anything else about it?