8000 Only build fsevents on macOS by rajivshah3 · Pull Request #322 · fsevents/fsevents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Only build fsevents on macOS #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send y 8000 ou account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Only build fsevents on macOS #322

merged 1 commit into from
Apr 30, 2020

Conversation

rajivshah3
Copy link
@rajivshah3 rajivshah3 commented Apr 24, 2020 •
edited
Loading

Fixes #301

According to the npm docs, if a binding.gyp is detected, npm will run node-gyp rebuild by default unless an install script is specified. For some reason, even though 'OS=="mac"' is specified in the binding.gyp, it builds on Windows anyway. This PR adds an install script that checks the platform and only runs node-gyp rebuild if a macOS environment is detected.

@rajivshah3 rajivshah3 mentioned this pull request Apr 24, 2020
Closed
@rajivshah3 rajivshah3 force-pushed the fix/only-build-on-macos branch from 0ee91db to 9a50fcc Compare April 24, 2020 18:41
pipobscure
pipobscure approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor
@pipobscure pipobscure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge and release soonish.

@richbern
Copy link

Any chance we can get an estimate better than "soonish"?

@pipobscure pipobscure merged commit f393f2a into fsevents:v1.x Apr 30, 2020
@rajivshah3 rajivshah3 deleted the fix/only-build-on-macos branch April 30, 2020 16:57
@pipobscure
Copy link
Contributor

It’s merged an will be published this weekend (hopefully).

@richardlau richardlau mentioned this pull request May 1, 2020
Closed
@wbt
Copy link
wbt commented May 5, 2020

Thanks much for doing this work and merging it in!
I see that the release/publish did not happen this weekend. Are there things we can do to help move it along?

@rajivshah3
Copy link
Author

I think it was published just 2 hours ago: https://www.npmjs.com/package/fsevents/v/1.2.13

@wbt
Copy link
wbt commented May 5, 2020

@rajivshah3 Ah, OK. I was looking here; my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipobscure pipobscure pipobscure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajivshah3 @richbern @pipobscure @wbt
0