Content Atom and Quiz models - updated after whiteboard discussion #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a thrift spec
'quiz' atom type was storing creation time etc which is duplicated at the 'atom' level
| 1: quiz.QuizAtom quiz | ||
| } | ||
|
|
||
| enum EventType { PUBLISH, UPDATE, TAKEDOWN } |
There was a problem hiding this comment.
I think we agreed PUBLISH was not needed
|
This looks good to me, I have added 2 minor comments. |
paulmr
added a commit
that referenced
this pull request
Sep 4, 2015
Content Atom and Quiz models - updated after whiteboard discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, I have now updated the Content Atom and Quiz models after our discussion yesterday (notes are here) and also the comments in the previous PR (#1, which this replaces).