Reattempt fixing react for shared eslint configs #2088
Merged
+225
−1,647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…their own config objects""
🦋 Changeset detectedLatest commit: ab53ce9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
<
8000
span class="Skeleton d-inline-block" style="width:12px; height:12px;">
oliverabrahams
approved these changes
May 21, 2025
There was a problem hiding this comment.
Thanks again for fixing this @andrew-nowak !
@andrewHEguardian @coldlink -- looks like this maybe an issue with the cache not invalidating when there are changes to the @guardian/eslint package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back #2079
#2079 caused some odd problems after merge - the CI run after merge succeeded, but then subsequent runs failed with cryptic error messages. Searching those messages on stack overflow brought me to https://stackoverflow.com/a/77464178 which suggests this is due to mismatching versions of a dependency, and to try running
pnpm dedupe. I've done that, and it did manage to dedupe some things so that seems plausible. More concrete, once I'd deduped the dependency tree I started seeing some new linting failures coming from the crossword component, which needed fixing -- which seems to me to strongly suggest we've now got a working dependency tree! 🎉