8000 Improve ticker animation by tomrf1 · Pull Request #2089 · guardian/csnx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve ticker animation #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Improve ticker animation #2089

merged 3 commits into from
May 22, 2025

Conversation

tomrf1
Copy link
Member
@tomrf1 tomrf1 commented May 20, 2025 •
edited
Loading

What are you changing?

The animation of the ticker.

Why?

On some devices the animation can be very slow/jerky.
The new implementation smoothes it out by setting a fixed animation duration, and using requestAnimationFrame to base the ticker increments around the browser's rendering cycle.

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 20, 2025
@tomrf1 tomrf1 added 🐥 Canaries Triggers canary releases of any packages with changesets waiting. and removed 📦 npm Affects a @guardian package on NPM labels May 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 20, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f45492

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@tomrf1 tomrf1 marked this pull request as ready for review May 21, 2025 08:24
@tomrf1 tomrf1 requested review from a team as code owners May 21, 2025 08:24
sookburt
sookburt approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor
@sookburt sookburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@tomrf1 tomrf1 enabled auto-merge (squash) May 22, 2025 10:23
@tomrf1 tomrf1 disabled auto-merge May 22, 2025 10:23
@tomrf1 tomrf1 added the run_chromatic Runs chromatic when label is applied label May 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@tomrf1 tomrf1 merged commit 22b7d0d into main May 22, 2025
23 checks passed
@tomrf1 tomrf1 deleted the tf-ticker-anim branch May 22, 2025 10:31
@tomrf1 tomrf1 mentioned this pull request May 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sookburt sookburt sookburt approved these changes

@LAKSHMIRPILLAI LAKSHMIRPILLAI LAKSHMIRPILLAI approved these changes

@andrewHEguardian andrewHEguardian andrewHEguardian approved these changes

Assignees
No one assigned
Labels
🐥 Canaries Triggers canary releases of any packages with changesets waiting. 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomrf1 @sookburt @LAKSHMIRPILLAI @andrewHEguardian
0