8000 refactor: Use webauthn library native JSON encodings by kelvin-chappell · Pull Request #579 · guardian/janus-app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Use webauthn library native JSON encodings #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

refactor: Use webauthn library native JSON encodings #579

merged 2 commits into from
May 21, 2025

Conversation

kelvin-chappell
Copy link
Member

What is the purpose of this change?

Instead of using handwritten play-json encodings this change makes use of the Json annotations that have already been attached to the models of the webauthn4j library.

What is the value of this change and how do we measure success?

This is to avoid having to remember to update Json encodings whenever we use an extra field. It also gives us more consistency in that we're now using the webauthn4j library to encode and to decode Json in web requests and responses.

Any additional notes?

This is to pave the way for adding excludeCredentials argument to our PublicKeyCredentialCreationOptions, which in turn will stop the possibility of registering duplicate and therefore redundant passkeys.

@kelvin-chappell kelvin-chappell requested a review from a team May 20, 2025 15:39
tjsilver
tjsilver approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will this also help when we come to try and identify the passkey type further down the line?

@kelvin-chappell
Copy link
Member Author

Will this also help when we come to try and identify the passkey type further down the line?

Yes, we should be able to change val attestation: AttestationConveyancePreference = NONE to get more info

@kelvin-chappell kelvin-chappell merged commit a867a54 into main May 21, 2025
6 checks passed
@kelvin-chappell kelvin-chappell deleted the kc/json branch May 21, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjsilver tjsilver tjsilver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvin-chappell @tjsilver
0