feat: Improve passkey registration to prevent duplicate entries #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/models/Passkey.scala
tjsilver
reviewed
May 22, 2025
No, this is my limited testing. Thanks for pointing it out! I'll investigate. |
tjsilver
reviewed
May 22, 2025
tjsilver
approved these changes
May 22, 2025
Co-authored-by: TJ Silver <15648334+tjsilver@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
We now send an excludeCredentials attribute in our pre-registration options call, which contains details of the user's existing passkeys. If they try to register a passkey of the same type twice they will get an
InvalidStateError, which we trap with a warning toast.What is the value of this change and how do we measure success?
This will ensure that we don't end up with redundant and useless passkeys in the Janus database. If a passkey of the same type is registered twice, the first one will be overwritten on the authenticator and therefore its record in the Janus database will be useless. By intercepting the registration on the browser we avoid a new passkey of the same type being generated at all.