8000 Don't collapse PBA table in security report on data change by shreyamalviya · Pull Request #1453 · guardicore/monkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't collapse PBA table in security report on data change #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2021
Merged

Don't collapse PBA table in security report on data change #1453

merged 2 commits into from
Sep 7, 2021

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #1423

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running Monkey Island

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link
codecov bot commented Sep 6, 2021 •
edited
Loading

Codecov Report

Merging #1453 (f917258) into develop (57908b9) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1453      +/-   ##
===========================================
+ Coverage    41.33%   41.38%   +0.04%     
===========================================
  Files          466      466              
  Lines        13947    13984      +37     
===========================================
+ Hits          5765     5787      +22     
- Misses        8182     8197      +15
Impacted Files Coverage Δ
monkey/monkey_island/cc/app.py 76.50% <0.00%> (-3.06%) ⬇️
monkey/monkey_island/cc/environment/__init__.py 78.78% <0.00%> (-1.22%) ⬇️
...key_island/cc/environment/environment_singleton.py 45.71% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57908b9...f917258. Read the comment docs.

@shreyamalviya shreyamalviya force-pushed the bugfix-expanded-report-reset branch from aed7038 to f917258 Compare September 6, 2021 13:05
@shreyamalviya shreyamalviya merged commit eefd7a6 into develop Sep 7, 2021
@shreyamalviya shreyamalviya deleted the bugfix-expanded-report-reset branch September 7, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expanded report details automatically reset
2 participants
@shreyamalviya @ilija-lazoroski
0