8000 Remove unused and broken package gathering feature on windows. by VakarisZ · Pull Request #1431 · guardicore/monkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unused and broken package gathering feature on windows. #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2021
Merged

Remove unused and broken package gathering feature on windows. #1431

merged 2 commits into from
Aug 30, 2021

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes #1389

PR Checklist

  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unprivileged monkey (from source and binary) on windows.

shreyamalviya
shreyamalviya approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor
@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this change has been tested properly, approved.

mssalvatore
mssalvatore requested changes Aug 30, 2021
View reviewed changes
Copy link
Collaborator
@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs a changelog entry.

@VakarisZ VakarisZ force-pushed the win_package_gathering branch from cacc1f0 to d8b6973 Compare August 30, 2021 13:48
mssalvatore
mssalvatore requested changes Aug 30, 2021
View reviewed changes
CHANGELOG.md Outdated
@@ -16,6 +16,7 @@ Changelog](https://keepachangelog.com/en/1.0.0/).
internet access checks. #1402
- Disused traceroute binaries. #1397
- "Back door user" post-breach action. #1410
- Stale code. #1431
Copy link
Collaborator
@mssalvatore mssalvatore Aug 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we should prefer the issue number to the PR number. The issues generally give more context than the PRs, and you can make your way to the PR from the issue.

This entry needs a little more detail for a human to understand what this change is.

Suggested change
- Stale code. #1431
- Stale code in the Windows system info collector that collected installed packages and WMI info. #1389

@mssalvatore mssalvatore force-pushed the win_package_gathering branch from d8b6973 to 248ec9a Compare August 30, 2021 13:54
@mssalvatore mssalvatore merged commit 0635169 into develop Aug 30, 2021
@mssalvatore mssalvatore deleted the win_package_gathering branch August 30, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore requested changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows package gathering fails
3 participants
@VakarisZ @mssalvatore @shreyamalviya
0