8000 1640 simplify log download by VakarisZ · Pull Request #1688 · guardicore/monkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1640 simplify log download #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 31, 2022
Merged

1640 simplify log download #1688

merged 7 commits into from
Jan 31, 2022

Conversation

VakarisZ
Copy link
Contributor
@VakarisZ VakarisZ commented Jan 31, 2022 •
edited
Loading

What does this PR do?

Fixes #1640

  • Streamlines log download procedure by making all logs downloadable from a single page in UI
  • Renames "Logs" page to "Telemetries", because it actually displays telemetries, not logs

image
image
image

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by downloading monkey logs from island
    Tested by downloading island logs from island
    Tested by downloading monkey logs from another machine

  • If applicable, add screenshots or log transcripts of the feature working

8000
@codecov
Copy link
codecov bot commented Jan 31, 2022 •
edited
Loading

Codecov Report

Merging #1688 (3e5c1c8) into develop (2399d1b) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e5c1c8 differs from pull request most recent head 3bed991. Consider uploading reports for the commit 3bed991 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1688   +/-   ##
========================================
  Coverage    45.56%   45.56%           
========================================
  Files          470      470           
  Lines        13760    13760           
========================================
  Hits          6270     6270           
  Misses        7490     7490

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2399d1b...3bed991. Read the comment docs.

mssalvatore
mssalvatore requested changes Jan 31, 2022
View reviewed changes
docs/content/FAQ/_index.md Outdated
Comment on lines 172 to 173
If logs can't be downloaded through the UI,
you can extract log files directly from the machine.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
8000
If logs can't be downloaded through the UI,
you can extract log files directly from the machine.
If the logs can't be downloaded through the UI for any reason,
you can collect the log files directly from the machine where and Agent or Monkey Island ran.

@mssalvatore mssalvatore merged commit 81bc579 into develop Jan 31, 2022
@mssalvatore mssalvatore deleted the 1640-simplify-log-download branch January 31, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
612D

@mssalvatore mssalvatore mssalvatore approved these changes

@shreyamalviya shreyamalviya shreyamalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify agent log download
3 participants
@VakarisZ @mssalvatore @shreyamalviya
0