8000 Remove "/api/client-monkey" endpoint by ilija-lazoroski · Pull Request #1895 · guardicore/monkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove "/api/client-monkey" endpoint #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2022
Merged

Remove "/api/client-monkey" endpoint #1895

merged 3 commits into from
Apr 18, 2022

Conversation

ilija-lazoroski
Copy link
Contributor
@ilija-lazoroski ilija-lazoroski commented Apr 18, 2022 •
edited
Loading

What does this PR do?

Fixes #1889.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Explain Changes

Are the commit messages enough? If not, elaborate.

@codecov
Copy link
codecov bot commented Apr 18, 2022 •
edited
Loading

Codecov Report

Merging #1895 (38714bb) into develop (e9895a0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1895   +/-   ##
========================================
  Coverage    54.89%   54.90%           
========================================
  Files          447      446    -1     
  Lines        12655    12637   -18     
========================================
- Hits          6947     6938    -9     
+ Misses        5708     5699    -9
Impacted Files Coverage Δ
monkey/monkey_island/cc/app.py 76.85% <ø> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9895a0...38714bb. Read the comment docs.

@mssalvatore mssalvatore merged commit 825fe33 into develop Apr 18, 2022
@mssalvatore mssalvatore deleted the 1889-remove-client-monkey-endpoint branch April 18, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya approved these changes

@mssalvatore mssalvatore Awaiting requested review from mssalvatore

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused /api/client-monkey endpoint
3 participants
@ilija-lazoroski @shreyamalviya @mssalvatore
0