8000 Add T1158 attack technique by shreyamalviya · Pull Request #674 · guardicore/monkey · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add T1158 attack technique #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 24, 2020
Merged

Add T1158 attack technique #674

merged 19 commits into from
Jun 24, 2020

Conversation

shreyamalviya
Copy link
Contributor

What is this?
Fixes #672

@shreyamalviya shreyamalviya force-pushed the T1158 branch 2 times, most recently from cce131d to 1c1a27a Compare June 4, 2020 19:08
@codecov
Copy link
codecov bot commented Jun 4, 2020 •
edited
Loading

Codecov Report

Merging #674 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #674   +/-   ##
========================================
  Coverage    58.06%   58.06%           
========================================
  Files          139      139           
  Lines         4483     4483           
========================================
  Hits          2603     2603           
  Misses        1880     1880
Impacted Files Coverage Δ
monkey/monkey_island/cc/services/config_schema.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0872730...a11852c. Read the comment docs.

ShayNehmad
ShayNehmad reviewed Jun 7, 2020
View reviewed changes
ShayNehmad
ShayNehmad reviewed Jun 7, 2020
View reviewed changes
ShayNehmad
ShayNehmad reviewed Jun 7, 2020
View reviewed changes
ShayNehmad
ShayNehmad reviewed Jun 7, 2020
View reviewed changes
ShayNehmad
ShayNehmad suggested changes Jun 7, 2020
View reviewed changes
Copy link
Contributor
@ShayNehmad ShayNehmad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good for a first version! I've left some comments.
Please also note that the Travis CI build is failing because of too many JavaScript warnings. https://travis-ci.com/github/guardicore/monkey/builds/169926081#L1228

@shreyamalviya shreyamalviya marked this pull request as ready for review June 7, 2020 18:47
@shreyamalviya shreyamalviya changed the title [WIP] Add T1158 attack technique Add T1158 attack technique Jun 7, 2020
@acepace
Copy link
Contributor
acepace commented Jun 16, 2020

Late to the game but why shell commands rather than calling APIs directly?

acepace
acepace reviewed Jun 17, 2020
View reviewed changes
acepace
acepace reviewed Jun 17, 2020
View reviewed changes
acepace
acepace reviewed Jun 17, 2020
View reviewed changes
@shreyamalviya shreyamalviya force-pushed the T1158 branch 2 times, most recently from 1abbdc5 to 67fc9f9 Compare June 22, 2020 09:33
@shreyamalviya
Copy link
Contributor Author

Late to the game but why shell commands rather than calling APIs directly?

@acepace, just that it's easier to fit it into the existing framework we have right now

@shreyamalviya shreyamalviya force-pushed the T1158 branch 2 times, most recently from ab15bb6 to 7ba7b62 Compare June 24, 2020 10:51
@shreyamalviya
Pass build
a11852c 
Pass build
@shreyamalviya shreyamalviya merged commit b0a5c9e into guardicore:develop Jun 24, 2020
@shreyamalviya shreyamalviya deleted the T1158 branch August 3, 2020 04:57
@snyk-bot snyk-bot mentioned this pull request May 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acepace acepace acepace left review comments

@ShayNehmad ShayNehmad ShayNehmad approved these changes

@VakarisZ VakarisZ Awaiting requested review from VakarisZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Hidden Files and Directories" attack technique (T1158)
3 participants
@shreyamalviya @acepace @ShayNehmad
0