Pay outlays #77
Merged
Pay outlays #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnuf
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
ack!
just had to make it so that Prism.pay had a default value of None rather than a type of None so that calling lightning-cli prism-pay ... would work
I tested with everyone online, and then with closing a channel and taking a peer offline.
One member accumulated an outlay, then when channel was back up, the outlay successfully cleared!
Ready to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where outlays were not used when setting the payment amount. This is fine for something like prism.pay, but for bindings, outlay values should be used for the payout amount.